Unify message clearing & broadcast logic #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchia
approved these changes
Oct 18, 2024
packages/jupyter-ai/src/components/chat-messages/chat-message-delete.tsx
Show resolved
Hide resolved
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* remove unused `StopMessage` backend model * fixup * remove unused `after` attr on `ClearRequest` * unify message clearing logic into `on_clear_request()` * unify message broadcast logic into `broadcast_message()` * pre-commit * fix typing issues raised by mypy * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RootChatHandler.on_clear_request(). Now, the backend history & memory models are cleared before aClearMessageis broadcast to all clients.ClearChatHandlernow just callsRootChatHandler.on_clear_request().BaseChatHandler.broadcast_message()method, which removes duplicate logic for broadcasting messages scattered across different methods.StopMessagebackend model accidentally merged with Allow users to stop message streaming #1022.ClearRequest.afterfield in frontend & backend models that should have been reverted before merging Add ability to delete messages + start new chat session #951.ClearRequest.targets: Optional[List[str]]field can be added. Some of the methods involved with clearing messages still accept a list of message IDs, so this change shouldn't be too difficult if needed.Demo
Screen.Recording.2024-10-18.at.8.45.24.AM.mov